Open
Conversation
vstinner
reviewed
Mar 27, 2026
|
|
||
|
|
||
| _ROOT_IN_POSIX = hasattr(os, 'geteuid') and os.geteuid() == 0 | ||
| requires_root = unittest.skipUnless(_ROOT_IN_POSIX, "test needs root privilege") |
Member
There was a problem hiding this comment.
Can you rename these decorators to requires_root_user and requires_non_root_user? At the first look, I wasn't sure what "root" was about. Root window? Root what? :-) Or maybe requires_root_privilege?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, when looking into unrelated changes, I realized that the check for root privilege is duplicated on several places and can be moved to test.support.
This change also improves
test_ownership_after_flushbecause without root, it skips it before running potentially slowpwd.getpwall.I am unsure whether this is trivial enough to not require an issue - I am happy to create one if that is not the case.